Skip to content

fix(utils): make ExitCode #[must_use] #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Jul 17, 2024

This PR is a continuation of #3952 to "properly" address similar linting-related issues regarding ExitCode.

I should've done this yesterday, but it didn't occur to me till this morning... Still it's better late than never.

@rami3l rami3l added this to the 1.28.0 milestone Jul 17, 2024
@rami3l rami3l requested a review from djc July 17, 2024 01:32
@rami3l rami3l force-pushed the fix/exit-code-must-use branch from 05b37ff to a796e7a Compare July 17, 2024 01:42
@rami3l rami3l force-pushed the fix/exit-code-must-use branch from a796e7a to a2712dc Compare July 17, 2024 01:44
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@rami3l rami3l added this pull request to the merge queue Jul 17, 2024
Merged via the queue into rust-lang:master with commit e835ca4 Jul 17, 2024
27 checks passed
@rami3l rami3l deleted the fix/exit-code-must-use branch July 17, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants