test(cli-rustup): migrate to .expect() APIs
#4365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami3l
changed the title
.expect() APIs
1 task
rami3l
force-pushed
the
test-new-api-6
branch
2 times, most recently
from
05520b7 to
bd65f73
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the CLI tests to use the updated .expect() APIs.
- Introduces a new remove_redactions method in the Assert struct.
- Updates expect and expect_with_env functions to be generic over types implementing AsRef with added Debug and Clone bounds, and changes how the command is executed by converting the first argument with to_str().
djc
approved these changes
Jun 5, 2025
|
@djc Many thanks for the reviewing efforts! The remaining patches should be significantly shorter :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4359.
Warning
This PR is very long.
I won't suggest reviewing it until it is marked ready.SemanticDiff