Skip to content

Update asyncronous dependencies #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2020
Merged

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented May 15, 2020

  • Updated tokio, reqwest, base64 and tiny_http
  • Removed tokio-process (Deprecated in favor of the process feature of tokio)
  • Replaced futures with futures-util and updated (Less dependencies, the extra features of futures weren't being used)

@jyn514
Copy link
Member

jyn514 commented May 15, 2020

If you update base64 to 0.11 it will remove another duplicate dependency:

$ cargo tree -d
base64 v0.10.1
└── rustwide v0.6.1 (/home/joshua/src/rustwide)

base64 v0.11.0
└── reqwest v0.10.4
    └── rustwide v0.6.1 (/home/joshua/src/rustwide)
...

@jyn514
Copy link
Member

jyn514 commented May 15, 2020

tiny_http also causes a lot of duplicates, you could try updating it to 0.7. It's only a dev-dependency though.

@jyn514
Copy link
Member

jyn514 commented May 16, 2020

Updating to base64 0.12 actually introduced a duplicate, up to you whether you think it's worth fixing or not.

cargo tree -d
base64 v0.11.0
└── reqwest v0.10.4
    └── rustwide v0.6.1 (/home/joshua/src/rustwide)

base64 v0.12.1
└── rustwide v0.6.1 (/home/joshua/src/rustwide)

@pietroalbini pietroalbini merged commit 1fab5bf into rust-lang:master May 18, 2020
@pietroalbini
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants