categorize sandbox creation failure

CHANGELOG.md

@@ -5,6 +5,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Added 
+
+- New variant `CommandError::SandboxContainerCreate`
+
 ## [0.18.0] - 2024-10-13
 
 - **BREAKING**  Extend `CommandError::ExecutionFailed` and `PrepareError` to optionally include stderr

src/build.rs

@@ -42,7 +42,7 @@ pub struct BuildBuilder<'a> {
     patches: Vec<CratePatch>,
 }
 
-impl<'a> BuildBuilder<'a> {
+impl BuildBuilder<'_> {
     /// Add a git-based patch to this build.
     /// Patches get added to the crate's Cargo.toml in the `patch.crates-io` table.
     /// # Example
@@ -170,7 +170,7 @@ impl BuildDirectory {
         toolchain: &'a Toolchain,
         krate: &'a Crate,
         sandbox: SandboxBuilder,
-    ) -> BuildBuilder {
+    ) -> BuildBuilder<'a> {
         BuildBuilder {
             build_dir: self,
             toolchain,

src/cmd/mod.rs

@@ -95,6 +95,10 @@ pub enum CommandError {
     #[error("sandbox image missing from the local system: {0}")]
     SandboxImageMissing(#[source] Box<CommandError>),
 
+    /// Failed to create the sandbox container
+    #[error("sandbox container could not be created: {0}")]
+    SandboxContainerCreate(#[source] Box<CommandError>),
+
     /// Running rustwide inside a Docker container requires the workspace directory to be mounted
     /// from the host system. This error happens if that's not true, for example if the workspace
     /// lives in a directory inside the container.
@@ -165,7 +169,7 @@ pub trait Runnable {
     }
 }
 
-impl<'a> Runnable for &'a str {
+impl Runnable for &str {
     fn name(&self) -> Binary {
         Binary::Global(self.into())
     }
@@ -177,7 +181,7 @@ impl Runnable for String {
     }
 }
 
-impl<'a, B: Runnable> Runnable for &'a B {
+impl<B: Runnable> Runnable for &B {
     fn name(&self) -> Binary {
         Runnable::name(*self)
     }

src/cmd/sandbox.rs

@@ -282,7 +282,8 @@ impl SandboxBuilder {
 
         let out = Command::new(workspace, "docker")
             .args(&args)
-            .run_capture()?;
+            .run_capture()
+            .map_err(|err| CommandError::SandboxContainerCreate(Box::new(err)))?;
         Ok(Container {
             id: out.stdout_lines()[0].clone(),
             workspace,

src/native/windows.rs

@@ -60,7 +60,7 @@ mod tests {
     #[test]
     fn test_kill_process() {
         // Try to kill a sleep command
-        let mut cmd = Command::new("timeout").args(&["2"]).spawn().unwrap();
+        let mut cmd = Command::new("timeout").args(["2"]).spawn().unwrap();
         kill_process(cmd.id()).unwrap();
 
         // Ensure it returns the code passed to `TerminateProcess`

src/utils.rs

@@ -183,7 +183,7 @@ mod windows_tests {
             let first_component = p.components().next().unwrap();
 
             if let Component::Prefix(prefix) = &first_component {
-                let stripped = strip_verbatim_from_prefix(&prefix);
+                let stripped = strip_verbatim_from_prefix(prefix);
                 assert_eq!(stripped.as_ref().map(|p| p.to_str().unwrap()), output);
             } else {
                 assert!(output.is_none());