Skip to content

Use .text as the section name for area directives in armasm files #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

danielframpton
Copy link
Contributor

Closes #37

The directive AREA CODE, READONLY was creating a section named CODE that was non-executable when built for aarch64-pc-windows-msvc.

This change names the .text section ensuring the CODE attribute is applied.

@nagisa nagisa merged commit ce83dfa into rust-lang:master Jun 25, 2020
@nagisa
Copy link
Member

nagisa commented Jun 25, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aarch64 armasm weirdness on AREA directive
2 participants