Skip to content

fix broken links #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix broken links #36

wants to merge 1 commit into from

Conversation

yaahc
Copy link
Member

@yaahc yaahc commented May 31, 2022

should also figure out why these aren't being caught by CI

@yaahc
Copy link
Member Author

yaahc commented May 31, 2022

seems like the tests are failing too, despite passing in #35, I'm very confused :/

@yaahc
Copy link
Member Author

yaahc commented May 31, 2022

@GuillaumeGomez do you know how to get mdbook to not treat indented code blocks like the one in https://github.com/rust-lang/std-dev-guide/blob/master/src/documentation/how-to-write-documentation.md#code-blocks as source code for tests? I think it's trying to compile them as rust code doc tests and barfing on the "```"

@GuillaumeGomez
Copy link
Member

You can't, you have to change it to another kind of code block. Do you want me to send a fix for them?

@yaahc
Copy link
Member Author

yaahc commented Jun 1, 2022

You can't, you have to change it to another kind of code block. Do you want me to send a fix for them?

yes please

@yaahc
Copy link
Member Author

yaahc commented Jun 2, 2022

superseded by #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants