Skip to content

Remove obsolete cfg for nvptx #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jan 19, 2023

This PR removes the last target_arch=nvptx in accordance to the compiler MCP 496 (rust-lang/compiler-team#496). It came up when cleaning up bootstrap extra cfgs (rust-lang/rust#107080).

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2023

r? @Amanieu

(rustbot has picked a reviewer for you, use r? to override)

@Urgau
Copy link
Member Author

Urgau commented Jan 19, 2023

Should I rename the nvptx module and all reference to nvptx64 ?

@Urgau
Copy link
Member Author

Urgau commented Jan 19, 2023

CI failure is fixed by #1371.

@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2023

LGTM! Can you rebase now that #1371 is merged?

Following to the compiler MCP 496
(rust-lang/compiler-team#496)
@Urgau Urgau force-pushed the remove-nvptx-cfgs branch from 84faff3 to 3a0b751 Compare January 22, 2023 17:22
@Urgau
Copy link
Member Author

Urgau commented Jan 22, 2023

LGTM! Can you rebase now that #1371 is merged?

Done. CI now pass.

@Amanieu Amanieu merged commit af225b6 into rust-lang:master Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants