Fix intrinsic-test for debug test suites #1771
Open
+33
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to have revealed compiler crashes. |
adamgemmell
commented
Apr 11, 2025
| @@ -30,6 +30,7 @@ run() { | |||
| --env NORUN \ | |||
| --env RUSTFLAGS \ | |||
| --env STDARCH_TEST_NORUN \ | |||
| --env PROFILE \ | |||
There was a problem hiding this comment.
Without this line the debug CI wasn't actually doing anything different to the release CI and it turns out quite a few platforms are broken in debug mode. Will keep digging.
There was a problem hiding this comment.
There's some handwritten arm intrinsics that have not been fixed by #1503, e.g.
stdarch/crates/core_arch/src/arm/neon.rs
Line 29 in 9091454
The wasm failure is due a hardcoded path to target/release. Not sure about freebsd, haven't looked into it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intrinsic-test tool itself was being built in dev/release profiles but the test programs it generates were all being tested in release mode. This PR pipes the GitHub Actions profile into the tool through a command line argument.