fix - aarch64_be tests #1786
fix - aarch64_be tests #1786
Conversation
| @@ -27,6 +27,7 @@ run() { | |||
| --env NOSTD \ | |||
| --env NORUN \ | |||
| --env RUSTFLAGS \ | |||
| --env CARGO_UNSTABLE_BUILD_STD \ | |||
There was a problem hiding this comment.
This doesn't seem to be used anywhere?
There was a problem hiding this comment.
It would get used by the CI, thinking about it; it probably makes sense for this PR to also include the code to make the CI run seeing as that's why these changes are being made
| ENV STDARCH_TEST_SKIP_FEATURE=tme | ||
| # The table instructions, while correct, generate some rev64 instructions which | ||
| # increases the number of instructions generated | ||
| ENV STDARCH_ASSERT_INSTR_LIMIT=32 |
There was a problem hiding this comment.
Currently all the logic for selecting the instruction limit is in crates/stdarch-test/src/lib.rs so it would be good to keep it there.
There was a problem hiding this comment.
Not exactly sure how to weave in something specific for aarch64_be without bloating out the file with changes. https://github.com/rust-lang/stdarch/blob/master/crates/stdarch-test/src/lib.rs#L119 there shows a check for; STDARCH_ASSERT_INSTR_LIMIT so I reasoned it was a standardised way of setting the instruction count limit?
There was a problem hiding this comment.
It's fine to just have a blanket rule for aarch64_be that sets the limit to 32, it's just that I would like that to be in stdarch-test/src/lib.rs instead of in the dockerfile.
|
CI failure seems to be fallout from rust-lang/rust#139261. |
Fixes issues that were surfaced through; #1776 (comment)
I've not hooked this up to the ci as it seems there is a PR in tow that will do that; #1785