Skip to content

Stabilize WebAssembly atomic intrinsics #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Oct 7, 2020

This commit stabilizes the wasm atomic intrinsics now that the threads
proposal has advanced to Stage 4, and is shipping in browsers.
Unfortunately these intrinsics still aren't available through the
precompiled versions of the standard library because atomics are no

This commit also updates the availability and documentation of these
intrinsics to reflect how they're always available, but they probably
won't work as expected unless shared memory is used (which isn't enabled
by default). This reflects a change in the threads proposal from the
last year or so where the instructions validate without requiring a
shared memory.

@rust-highfive
Copy link

r? @Amanieu

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

I sort of forget the precise procedure by which these intrinsics are stabilized, but I'd be happy to write up more information if desired! (or start with an issue elsewhere as well)

This commit stabilizes the wasm atomic intrinsics now that the threads
proposal has advanced to Stage 4, and is shipping in browsers.
Unfortunately these intrinsics still aren't available through the
precompiled versions of the standard library because atomics are no
@alexcrichton alexcrichton force-pushed the stabilize-wasm-threads branch from 15c607c to 30c9f35 Compare October 7, 2020 01:11
@alexcrichton
Copy link
Member Author

Looks like LLVM isn't as far along as I thought, so I left in the module being disabled without the atomics feature.

@Amanieu
Copy link
Member

Amanieu commented Oct 7, 2020

Is there a tracking issue for these? It needs an FCP before it can be stabilized. (rfcbot isn't enabled on this repo).

@alexcrichton
Copy link
Member Author

Ah yes, indeed! I will follow up with a tracking issue in rust-lang/rust and will cc the libs team there.

@alexcrichton
Copy link
Member Author

Ok I opened rust-lang/rust#77839, but upon reflection I don't think stabilization is a good idea at this time, so I'll be leaving it at that.

@alexcrichton alexcrichton deleted the stabilize-wasm-threads branch October 12, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants