Skip to content

Fix overflowing integer when retrieving comments for FCP #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apiraino
Copy link
Contributor

This is a patch I've been using locally since long, should be the final nail in the coffin to fix the overflowing GH ID issue we started experiencing a while ago.

I'd like to upstream it after some testing.

Copy link
Member

@Mark-Simulacrum Mark-Simulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to switch to u64 to preempt another round of problems.

@apiraino apiraino force-pushed the fix-overflowing-integer branch from 485e212 to b8921a8 Compare February 20, 2025 14:56
@apiraino
Copy link
Contributor Author

apiraino commented Feb 26, 2025

Note for myself to investigate before merge: using u64 causes a runtime error when retrieving issues

2025-02-26T16:29:55.830555Z DEBUG triagebot::github: send_req with RequestBuilder { method: GET, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("api.github.com")), port: None, path: "/search/issues", query: Some("q=state:open+no:assignee+label:T-compiler+label:P-critical+repo:rust-lang/rust&sort=created&order=asc&per_page=100&page=1"), fragment: None }, headers: {"user-agent": "rust-lang-triagebot", "authorization": Sensitive} }
...
Error: out of range integral type conversion attempted

The error happens here and it's due to parsing the JSON that goes into IssueSearchResult.issues which is a Vec<Issue>, so there must be some integer casting that fails inside there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants