Skip to content

Automatically indent warnings messages for check_commits sub-handler #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

Automatically indent warnings messages for check_commits sub-handler #1967

merged 1 commit into from
May 5, 2025

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented May 4, 2025

@Urgau Urgau requested a review from Kobzol May 4, 2025 10:17
Kobzol
Kobzol reviewed May 5, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please now add a test that will put some example set of warnings through warning_from_warnings and assert how does the result look like?

@Urgau Urgau force-pushed the check_commits-auto-ident branch from d9694d7 to 4894129 Compare May 5, 2025 16:50
@Urgau
Copy link
Member Author

Urgau commented May 5, 2025

Sure, done.

And sorry, the test it-self is horrible to look at, even after #[rustfmt::skip].

Kobzol
Kobzol approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@Kobzol Kobzol added this pull request to the merge queue May 5, 2025
Merged via the queue into rust-lang:master with commit 76b673c May 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Urgau @Kobzol