Skip to content

Formatting touches to the T-compiler triage agenda#2396

Merged
Urgau merged 1 commit into
rust-lang:masterfrom
apiraino:triage-agenda-fmt-tuning
May 28, 2026
Merged

Formatting touches to the T-compiler triage agenda#2396
Urgau merged 1 commit into
rust-lang:masterfrom
apiraino:triage-agenda-fmt-tuning

Conversation

@apiraino

@apiraino apiraino commented May 6, 2026

Copy link
Copy Markdown
Contributor

I've done some fine-tuning to the compile triage agenda generator.

  • Removed a mostly redundant query, replaced with adding a team label
  • Filtered out some more labels for FCPs we're not interested to see during triage

r? @Kobzol

thanks!

Comment thread .git-blame-ignore-revs

@apiraino apiraino May 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change: While I was bisecting some changes, I've added also this commit that was confusing git-blame

View changes since the review

@apiraino apiraino force-pushed the triage-agenda-fmt-tuning branch 2 times, most recently from 49c179d to 941e76e Compare May 7, 2026 12:29
@apiraino apiraino force-pushed the triage-agenda-fmt-tuning branch from 941e76e to 733ec61 Compare May 15, 2026 09:42
@apiraino apiraino force-pushed the triage-agenda-fmt-tuning branch from 733ec61 to 1fd50cd Compare May 15, 2026 09:58
@apiraino apiraino requested a review from Urgau May 28, 2026 08:50

@Urgau Urgau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the label changes, but we can always change them later, to a big deal anyway.

Let's try it.

View changes since this review

Comment thread src/github/issue_query.rs
let t_label = labels
.iter()
.find(|s| s.starts_with("T-"))
.map_or("", |v| v);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this will work reliably, since the order of labels is unrelated to the "owner" of the issue/PR, but let's try it.

Comment thread templates/prioritization_agenda.tt
Comment thread templates/_issue.tt
Comment on lines +2 to +4
{%- if with_team_tag %}[{{issue.team}}] {% endif %}
{%- if issue.is_blocked %}[blocked] {% endif %}"{{issue.title}}" [{{issue.repo_name}}#{{issue.number}}]({{issue.html_url}})
{%- if issue.mcp_details.zulip_link %} ([Zulip]({{issue.mcp_details.zulip_link}})){% endif %}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised those {% end %} don't require dashes - to prevent newlines, but this seems to work as expect. Nice.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure but I think it's because I eat the newline in the {%- if that follows immediately.

(formatting these templates is a bit of a chore...)

@Urgau Urgau added this pull request to the merge queue May 28, 2026
Merged via the queue into rust-lang:master with commit c4d0162 May 28, 2026
3 checks passed
@apiraino apiraino deleted the triage-agenda-fmt-tuning branch May 29, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants