Code completion just compatible with "LF" line ending

[Elementals]

As was originally mentioned here, code completion is not compatible with "CRLF" line ending.

Here I use Amethyst (game engine) as an example, but for simple projects which just using a rand crate the bug will appear too.
I'm not sure this is caused by the rls-vscode or RLS or Racer though.

Also, Racer require nightly rust, why you haven't mention this in the VSCode page? (And this causes huge difference indeed, never get code completion worked in stable rust.)

[nrc]

Also, Racer require nightly rust, why you haven't mention this in the VSCode page? (And this causes huge difference indeed, never get code completion worked in stable rust.)

It should work with any Rust if you're using the version installed by Rustup. Are you having problems with your own RLS build or with the Rustup one?

[Elementals]

I used Rustup to install the stable rust, with the extension installed properly but didn't run properly, and then I install nightly rust using Rustup, still got some problems (but slightly better than in stable). Finally I found out it was caused by line endings. So I switched back to see if this workaround applies to stable rust, but not.

So I installed both stable and nightly using Rustup, and using the extension from official (installed inside VS Code).

p.s. I'm using Windows.

[alvinhochun]

I'm using beta rust rustc 1.31.0-beta.19 (42053f9f0 2018-11-26) on Windows and code completion doesn't work unless files are in LF eol.

Having CRLF eol also caused other random issues like the outline panel going empty at times.

[doxxx]

I'm experiencing this issue as well on Windows with rust 1.31 (final).

[jonathansty]

Experiencing this the the MSVC toolchain of rustc 1.32.0-beta.6 (a01b0bf0f 2018-12-19).

Changing the line ending to LF for the file fixes the completion only for that file. Although the completion shows completions that are located in files that still use CRLF endings.

[doxxx]

If I were to guess, I'd say that the extra character in CRLF is throwing off a file offset calculation somewhere.

[Xanewok]

This was fixed in racer-rust/racer#1007 (18 days ago?), I believe the nightly rls should have the fix. Could you try the nightly version to see if it’s working there?

[doxxx]

Yeah, it's working with nightly rls.

[Elementals]

This was fixed in racer-rust/racer#1007 (18 days ago?), I believe the nightly rls should have the fix. Could you try the nightly version to see if it’s working there?

Yes, now it works properly after I update rust to latest version, the stable rust also works properly now. Good fix!
But the OUTLINE seems broken? It always says "No symbols found in document ...".