Skip to content

Conversation

@sophiajt
Copy link
Contributor

This adds a status quo story for Barbara based on our experience using async streams in Nushell.

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a very interesting story - Thank you! It certainly has a bit of overlap with #48. I wonder what if we can reword the morals in light of #48 existing so we have a clear take-away from this story other than what is already covered in #48.

@sophiajt
Copy link
Contributor Author

sophiajt commented Mar 29, 2021

@rylev - Happy to, though I don't have a clear idea for what you have in mind.

#48 is talking about the details of writing async streams and where they are difficuilt. This is great information that I don't go over in this PR.

It doesn't seem to cover what I cover in this PR: namely that it's easy to go down the wrong path, to miss that streams are just iterators, and to miss that they can't be operated on in parallel. If you like, I can use that summary as the morals.

@nikomatsakis
Copy link
Contributor

@jonathandturner that sounds helpful (using summary as morals)

@sophiajt
Copy link
Contributor Author

Updated

@nikomatsakis
Copy link
Contributor

Thanks @jonathandturner!

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I think this really highlights the issues of using streams where as the other stream story we have is about creating streams. Really great!

@nikomatsakis nikomatsakis merged commit 6b65c5a into rust-lang:master Mar 30, 2021
@nikomatsakis nikomatsakis added the status-quo-story-ideas "Status quo" user story ideas label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status-quo-story-ideas "Status quo" user story ideas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants