-
Notifications
You must be signed in to change notification settings - Fork 90
Refine polish section impact, define milestones #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,37 @@ | |
|
||
## Impact | ||
|
||
* Users can predict and understand why the compiler raises error messages. Errors are aligned with an experienced user's intuition about how Rust works. | ||
* Error messages identify common misconceptions, suggest solutions, and are generally on par with sync Rust. | ||
* Errors not only show that there is a problem, they help the user to fix it and to learn more about Rust (possibly directing the user to other documentation). | ||
* The compiler may suggest crates from the ecosystem to help solve problems when appropriate. | ||
* Lints guide the user away from common errors and help them both to get started with async Rust and to maintain async Rust programs over time. | ||
* Errors not only show that there is a problem, they help the user to fix it and to learn more about Rust (possibly directing the user to other documentation). | ||
* The generated code from the compiler is high quality and performant. | ||
* Integration with low-level tooling and the like is high-quality. | ||
* Rust's async implementation is high quality and reflects an attention to detail. | ||
* No internal compiler errors | ||
* Compiler analysis and code generation passes are precise and not unnecessarily conservative. | ||
* Integration with low-level tooling and the like is high-quality. | ||
* The generated code from the compiler is high quality and performant. | ||
|
||
## Milestones | ||
|
||
| Milestone | State | Key participants | | ||
| --- | --- | --- | | ||
| Precise generator captures | 🦀 | [eholk] | | ||
| ↳ Prototype | 🦀 | [eholk] | | ||
| ↳ Documented in Rust Reference | 🦀 | [eholk] | | ||
| ↳ [Lang team] signoff | 💤 | [Lang team] | | ||
| ↳ Stabilized | 💤 | [eholk] | | ||
| Lint: [Large copies], large generators | 💤 | | | ||
| ↳ [Lang team] initiative proposal | 💤 | | | ||
| ↳ Implementation | 💤 | | | ||
| Lint: [Must not suspend] | 💤 | | | ||
| ↳ Landed the [RFC] | 💤 | | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needs implementation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll rephrase as "Implemented the RFC." The RFC is already merged, so I think all we need to do is implement what the RFC says. |
||
| Lint: [Blocking in async context] | 💤 | | | ||
eholk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
|
||
[eholk]: https://github.com/eholk/ | ||
[Lang team]: https://www.rust-lang.org/governance/teams/lang | ||
[Blocking in async context]: ./polish/lint_blocking_fns.md | ||
[Large copies]: ./polish/lint_large_copies.md | ||
[Must not suspend]: ./polish/lint_must_not_suspend.md | ||
[RFC]: https://rust-lang.github.io/rfcs/3014-must-not-suspend-lint.html |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.