Skip to content

Use Rust 1.75's async fn in trait instead of #[async_trait] #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Jan 9, 2024

@dtolnay dtolnay requested a review from a team as a code owner January 9, 2024 22:54
@dtolnay
Copy link
Member Author

dtolnay commented Jan 9, 2024

Note there is no change to Cargo.toml because www-rust-lang-org does not depend directly on async-trait. This code was using rocket::async_trait via this, which puts it in scope in all modules:

#[macro_use]
extern crate rocket;

@Manishearth Manishearth merged commit 3db12c8 into rust-lang:master Jan 9, 2024
@dtolnay dtolnay deleted the asynctrait branch January 9, 2024 23:02
This was referenced Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants