Merged
Conversation
This uses the RtlCaptureContext replacement from crash-context, which also has correct bindings for CONTEXT. This also changes to use winapi for most bindings, other than some minidump related types/functions that are not provided by winapi.
Crash-context needs to add capture_context impl if needed Also just cleans up the markdown table to be easier to edit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
crash-contextto 0.5, which includes a replacementcapture_contextfunction forRtlCaptureContext. This was done because bothwinapiandwindows-sysprovide incorrect bindings due to not aligningCONTEXTand related structs correctly, which can result in crashes whenRtlCaptureContextis used. Additionally on x86_64, the replacement also captures floating point and vector state whichRtlCaptureContextdoesn't do.The other big change is that we now just bite the bullet and use
winapifor most of the other bindings used by this crate. I was initially against this in #58 because it felt like taking a step back, but most codebases will already depend onwinapi0.3 so it shouldn't matter to add the dependency, and does make it easier to interoperate with other crates.Resolves: #63