fix: enable the latest rtnetlink on Android #161
Merged
+41
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version of the rtnetlink crate cannot compile on Android. The reason is that Android uses the AddressFamily defined in address_family_fallback.rs, while the correct one should be that in address_family_linux.rs. This leads to AddressFamily::Bridge used in rtnetlink being undefined on Android. This patch fixes this by adding necessary target_os="android" configs. Since libc::AF_IB & libc::AF_MPLS are not defined on Android, we still confine branches related to those enums to only linux and fuchsia. Signed-off-by: chenzikai <[email protected]>
|
This is great news, any chance this could land in a patch release? would love to update to the latest version |
1 task
I opened #164 for more visibility, would be great to get this into the next iroh release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the rtnetlink crate cannot compile on Android. The reason is that Android uses the AddressFamily defined in address_family_fallback.rs, while the correct one should be that in address_family_linux.rs. This leads to
AddressFamily::Bridgeused in rtnetlink being undefined on Android.This patch fixes this by adding necessary
target_os="android"configs. Sincelibc::AF_IB&libc::AF_MPLSare not defined on Android, we still confine branches related to those enums to only linux and fuchsia.