Skip to content

fix HpetInfo::num_comparators #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Jul 31, 2022

This pr fixes the getter for the number of comparators for HPET.

The number in this field indicates the last timer (i.e. if there are three timers, the value will be 02h, four timers will be 03h, five timers will be 04h, etc.).
(IA-PC HPET Specification)

>  The number in this field indicates the last timer (i.e. if there are three timers, the
> value will be 02h, four timers will be 03h, five timers will be 04h,
> etc.). - (IA-PC HPET Specification)
Copy link
Member

@IsaacWoods IsaacWoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - thanks!

@IsaacWoods IsaacWoods merged commit 600c664 into rust-osdev:master Aug 1, 2022
@IsaacWoods
Copy link
Member

🚀 Published as acpi v4.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants