Skip to content

Incorrect environment variable access in create-disk-image example build script #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Johan-Mi opened this issue Dec 3, 2022 · 1 comment · Fixed by #296
Closed

Incorrect environment variable access in create-disk-image example build script #295

Johan-Mi opened this issue Dec 3, 2022 · 1 comment · Fixed by #296

Comments

@Johan-Mi
Copy link

Johan-Mi commented Dec 3, 2022

The example build.rs file in create-disk-image.md uses the env!() macro to access CARGO_BIN_FILE_KERNEL_kernel when it should use std::env::var_os.
@phil-opp phil-opp mentioned this issue Dec 7, 2022
Merged
@phil-opp
Copy link
Member

phil-opp commented Dec 7, 2022

Thanks a lot for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@phil-opp @Johan-Mi