Parse bootloader configuration from kernel's Cargo.toml #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails as expected since the bootimage crate doesn't pass |
phil-opp
reviewed
Aug 6, 2019
phil-opp
reviewed
Aug 6, 2019
phil-opp
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
Looks very good to me, thanks a lot!
The CI uses the manual build process instead of bootimage, so we need to update the azure-pipelines.yml to additionally pass the new KERNEL_MANIFEST environment variable. The relevant line is:
bootloader/azure-pipelines.yml
Line 99 in cda5eb6
|
Let me fix that warning... |
|
Thanks! |
phil-opp
added a commit
that referenced
this pull request
Aug 7, 2019
|
Published as version 0.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in rust-osdev/bootimage#44.
Requires support from the
bootimagecrate (so it knows where to find the kernel'sCargo.toml), and is also a breaking change as it removes support for the old environment variableBOOTLOADER_PHYSICAL_MEMORY_OFFSET.