Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was actually working on another thing (that I may or may not PR as it's more of a proof of concept) and in the process I've added a few macro checks with nice spans so it actually shows where stuff is wrong (guid one is especially cool) - and so here is a separate small PR with those things.
const _
bit was stabilized in 1.37 and is an idiomatic way of doing what was done before with ugly unhygienic static, and it's also done in a way that reuses existing ident token instead of creating a new one (as I did in my previous PR, basically fixing my own oversight) so the error highlight is also slightly better. And also I useexport_name
instead ofno_mangle
so that the function name still can be anything.btw now the 'based on this embedded library' is a bit more correct as this uses more of the same features now heh
prettified basic signature errors:



almost perfect typecheck (ideally spans would point at actual wrong types but that's impossible a token level sadly):
guid is chefs kiss: