Add a test command to build.py and also use it in the CI #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `build.py test` will now run tests and doctests using the host target.
This should ensure that the behavior of the local tests and CI don't get out of sync.
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this pull request
Sep 8, 2021
Use the [trybuild] crate to test the `unsafe_guid` and `entry` macros. The compilation output is compared against expected output to check the various error cases in the macros. Also updated the CI to run these tests, although that change should be obseleted by rust-osdev#283. [trybuild]: https://github.com/dtolnay/trybuild
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this pull request
Sep 8, 2021
Use the [trybuild](https://github.com/dtolnay/trybuild) crate to test the `unsafe_guid` and `entry` macros. The compilation output is compared against expected output to check the various error cases in the macros, which allows detailed tests covering things like the specific error messages and the associated spans. Also updated the CI to run these tests, although that change should be obseleted by rust-osdev#283.
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this pull request
Sep 8, 2021
Use the [trybuild](https://github.com/dtolnay/trybuild) crate to test the `unsafe_guid` and `entry` macros. The compilation output is compared against expected output to check the various error cases in the macros, which allows detailed tests covering things like the specific error messages and the associated spans. Also updated the CI to run these tests, although that change should be obseleted by rust-osdev#283.
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this pull request
Sep 8, 2021
Use the [trybuild](https://github.com/dtolnay/trybuild) crate to test the `unsafe_guid` and `entry` macros. The compilation output is compared against expected output to check the various error cases in the macros, which allows detailed tests covering things like the specific error messages and the associated spans. Also updated the CI to run these tests, although that change should be obseleted by rust-osdev#283.
nicholasbishop
added a commit
to nicholasbishop/uefi-rs
that referenced
this pull request
Sep 8, 2021
Use the [trybuild](https://github.com/dtolnay/trybuild) crate to test the `unsafe_guid` and `entry` macros. The compilation output is compared against expected output to check the various error cases in the macros, which allows detailed tests covering things like the specific error messages and the associated spans. Also updated the CI to run these tests, although that change should be obseleted by rust-osdev#283.
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #281