wayland: register drag & drop events#4009
Draft
PeakKS wants to merge 1 commit intorust-windowing:masterfrom
Draft
wayland: register drag & drop events#4009PeakKS wants to merge 1 commit intorust-windowing:masterfrom
PeakKS wants to merge 1 commit intorust-windowing:masterfrom
Conversation
Member
|
See #2429 it all should still apply. |
ea02bb2 to
2d5072e
Compare
Author
|
I think the functionality is correct now. |
|
I haven't made deep testing but in a simple application based on libcosmic with this patch applied, dropping a file on the window works on wayland too! Thanks! I did not review the code before applying. |
This was referenced Jan 2, 2025
5 tasks
|
Guys, any ping on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried implementing drag & drop on Wayland, though I don't think it is possible with the current PathBuf based API. The smithay client toolkit provides only a readpipe to get the file content from, and afaict there is no way to get the path from it.Tried a little harder and got it to work, still work to be done e.g. handling multiple file selections.
Related: #1881 #1550
changelogmodule if knowledge of this change could be valuable to users