fix tests (travis) #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikbosch
force-pushed
the
master
branch
2 times, most recently
from
c586aaa to
6521fbd
Compare
…ed over the method that should not be shared. cannot figure out how to fix it
frederikbosch
force-pushed
the
master
branch
from
5d9e29d to
e30391c
Compare
|
I cannot found the failure reason either, since my code works on my machine, can you trigger this error on your machine? If so, I think it wont' be hard to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to fix all tests, but I cannot discover the error in test 003. There is variable shared that is causing the method name to end up in the json structure. I have no idea how to fix it. Had multiple tries, but all failed. Lack of C knowledge.
But my guess is it has something to do with the
offsetSetmethod. More specifically with replacing a string because it seems not the case with integers. I guess we should not useStringRefbut something likeZVAL_COPY_VALUE.