Skip to content

feat!: Use ktls-recvmsg crate to add recvmsg fallback, closes #24 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 28, 2023

Conversation

fasterthanlime
Copy link
Collaborator

@fasterthanlime fasterthanlime commented Sep 27, 2023

Since the PR is taking a while to land.

This is a fork off of #26

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (7c377ca) 76.68% compared to head (c4ceb4b) 75.00%.

❗ Current head c4ceb4b differs from pull request most recent head 56d28b0. Consider uploading reports for the commit 56d28b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   76.68%   75.00%   -1.69%     
==========================================
  Files           4        5       +1     
  Lines         476      532      +56     
==========================================
+ Hits          365      399      +34     
- Misses        111      133      +22     
Files Coverage Δ
src/lib.rs 94.40% <100.00%> (ø)
src/async_read_ready.rs 0.00% <0.00%> (ø)
src/cork_stream.rs 79.83% <50.00%> (-4.24%) ⬇️
src/ktls_stream.rs 63.11% <74.50%> (+5.78%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasterthanlime fasterthanlime added this pull request to the merge queue Sep 28, 2023
@fasterthanlime fasterthanlime removed this pull request from the merge queue due to a manual request Sep 28, 2023
@fasterthanlime fasterthanlime changed the title Use ktls-recvmsg crate instead of the nix crate (WIP) feat!: Use ktls-recvmsg crate to add recvmsg fallback, closes #24 Sep 28, 2023
@fasterthanlime fasterthanlime added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit bf32251 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant