Span doesn't implement PartialEq and Eq

[c410-f3r]

Span doesn't implement PartialEq and Eq, making the extra-traits feature broken.
Should PartialEq and Eq be removed or is it better to wait for an implementation?

Related: #154

wasm-bindgen/crates/backend/src/ast.rs

Lines 200 to 210 in 9f6c2a6

	#[cfg_attr(feature = "extra-traits", derive(Debug, PartialEq, Eq))]
	#[derive(Clone)]
	pub struct Function {
	pub name: String,
	pub name_span: Span,
	pub renamed_via_js_name: bool,
	pub arguments: Vec<syn::ArgCaptured>,
	pub ret: Option<syn::Type>,
	pub rust_attrs: Vec<syn::Attribute>,
	pub rust_vis: syn::Visibility,
	}

[alexcrichton]

Oh dear this does seem bad! We probably want to remove this feature for now in that case? (removing PartialEq and Eq also seems fine to me)

[dtolnay]

I notice that ast::Function stores name: String and name_span: Span as separate fields. I would recommend storing these as one field of type proc_macro2::Ident which does have a PartialEq impl, or if the name is not guaranteed to be a legal Rust identifier/keyword then writing your own type similar to Ident to hold the name and span and provide PartialEq and any other traits you need.

[c410-f3r]

@dtolnay Thanks!