Overhaul the conversion traits #129
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit overhauls the conversion traits used for types crossing the Rust/JS boundary. Previously there were a few ad-hoc traits but now there's only two. One is for converting JS values to Rust values, `FromWasmAbi`, and the other is for converting Rust values into JS values, `IntoWasmAbi`. These two traits are now uniformly used for all operations such as creating references and such. The `IntoWasmAbi` trait is pretty straightforward but `FromWasmAbi` is much trickier. We need to be able to create references which necessitates a good deal of funkiness with the API, but it in general should work out alright. The goal of this commit is to reduce the number of traits in play so it's more straightforward which traits are used for closures.
|
This is a necessary prerequisite for #104 |
|
Oh dear I ended up merging this in 0e6325d rather than pushing to this commit by accident. In any case I realized right after posting this that these traits as written aren't sound, so I had to scale back and be a bit more conservative in the referenced commit (namely having multiple traits for creating Rust values from JS ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit overhauls the conversion traits used for types crossing the Rust/JS
boundary. Previously there were a few ad-hoc traits but now there's only two.
One is for converting JS values to Rust values,
FromWasmAbi, and the other isfor converting Rust values into JS values,
IntoWasmAbi. These two traits arenow uniformly used for all operations such as creating references and such.
The
IntoWasmAbitrait is pretty straightforward butFromWasmAbiis muchtrickier. We need to be able to create references which necessitates a good deal
of funkiness with the API, but it in general should work out alright.
The goal of this commit is to reduce the number of traits in play so it's more
straightforward which traits are used for closures.