Support closures with "rich" arguments #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for closures with arguments like strings and such. In other words, closures passed to JS can now have the same suite of arguments as all functions that can be exported from Rust, as one might expect! At this time due to the way trait objects work closures still cannot use types with references like `&str`, but bare values like `String` or `ImportedType` should work just fine. Closes #104
alexcrichton
force-pushed
the
closure-more-fun-types
branch
from
bffd67b to
c64f178
Compare
fitzgen
reviewed
Apr 16, 2018
| @@ -48,7 +48,7 @@ pub enum Descriptor { | |||
| F64, | |||
| Boolean, | |||
| Function(Box<Function>), | |||
| Closure(Box<Function>), | |||
| Closure(Box<Function>, bool), | |||
There was a problem hiding this comment.
IMO, it is time to make this a struct variant :-p
There was a problem hiding this comment.
Ah good idea, done in f80a706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for closures with arguments like strings and such. In
other words, closures passed to JS can now have the same suite of arguments as
all functions that can be exported from Rust, as one might expect!
At this time due to the way trait objects work closures still cannot use types
with references like
&str, but bare values likeStringorImportedTypeshould work just fine.
Closes #104