WIP: Add string

[jonathan-s]

Work in progress to add string.

[jonathan-s]

@fitzgen So when trying to add a new type to represent String similar to object and then add the method new. When testing that that the type is actually string it instead gives me the type object. I'm confused about that, any clues would be helpful.

[fitzgen]

Ah yes, this is a nasty corner of JS:

[fitzgen]

I don't know if we should make String::new return js::Object or if we should just skip bindings to it altogether (it really isn't that useful...).

We should test receiving a js::String and checking its length for sure though!

[fitzgen]

I don't know if we should make String::new return js::Object or if we should just skip bindings to it altogether (it really isn't that useful...).

For this PR, let's just skip it. We can think it over in the meantime.

[jonathan-s]

String.length is a property of string. So instead of using method in the macro above the function I presume you should be using getter? Though if you use getter you can't use .length on the rust js string as it doesn't exist and using .length() won't work either. So there seems to be something I'm missing here.

On Thu 21. Jun 2018 at 00:56, Nick Fitzgerald ***@***.***> wrote: I don't know if we should make String::new return js::Object or if we should just skip bindings to it altogether (it really isn't that useful...). For this PR, let's just skip it. We can think it over in the meantime. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#281 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBsEvY9XRdN7zuEjjtS91XA0gJ2inWwks5t-tMYgaJpZM4UwI3e> .

-- Sent from Gmail Mobile

[fitzgen]

Here is an example of using JS getters and setters from Rust code:

wasm-bindgen/examples/import_js/src/lib.rs

Lines 16 to 19 in 151acf8

	#[wasm_bindgen(method, getter)]
	fn number(this: &MyClass) -> u32;
	#[wasm_bindgen(method, setter)]
	fn set_number(this: &MyClass, number: u32) -> MyClass;

The Rust side ends up doing .length() but it is translated into a get on the JS thing.