Allow non-literal constants in typescript_custom_section
#3115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Bump version to 0.2.84, since the internal schema is changing. - Bump MSRV for UI tests to 1.57 to allow `assert!` in `const fn`s. - Update UI test outputs.
|
Huh, renaming a branch from GitHub considers that the branch is deleted in open PRs. I made the same PR again in #3308. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
assert!inconst fns.This will, among other things, allow
include_str!in#[wasm_bindgen(typescript_custom_section)](and fix #2828). This also opens the door for non-literal constants ininline_js(thus fixing #2787) with minimal changes.