js-sys: Add extends attributes for js_sys::Number #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bokuweb
force-pushed
the
number-extends-attributes
branch
from
516baf0 to
f471aff
Compare
fitzgen
reviewed
Aug 9, 2018
crates/js-sys/tests/wasm/Number.rs
Outdated
| use wasm_bindgen::JsValue; | ||
| use wasm_bindgen_test::*; | ||
| use js_sys::*; | ||
|
|
||
| #[wasm_bindgen_test] | ||
| fn number_inheritance() { | ||
| let number: i32 = 10; |
There was a problem hiding this comment.
This line should be:
let number = Number::new(&JsValue::from(10));Note that if you open a JS console:
> 10 instanceof Number
false
> new Number(10) instanceof Number
true
JS has a distinction between Number objects and its number values, which is a bit tricky!
bokuweb
force-pushed
the
number-extends-attributes
branch
from
f471aff to
42e02f7
Compare
|
Thanks for your quick response :) On this occasion I will learn about |
fitzgen
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #670