feat(extends): extend promise #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertohuertasm
force-pushed
the
feat/extends-promise
branch
from
cb2749f to
042cfad
Compare
fitzgen
approved these changes
Aug 24, 2018
There was a problem hiding this comment.
LGTM!
The appveyor CI failure looks like infra issues on their end, but I don't have perms to restart it. +cc @alexcrichton
Thanks @robertohuertasm!
|
@fitzgen I've just seen your message. I pushed a new commit amend to force |
|
I guess we're not 😜 |
|
Ah yeah this is fine, thanks! We'll see what happens with AppVeyor later probably... |
FWIW, I've seen that Cargo error on my own personal windows machine several times. It always clears up by itself a minute later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #670
Extends
Promise.