Skip to content

Add the last four bindings for Object #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2018
Merged

Add the last four bindings for Object #854

merged 4 commits into from
Sep 19, 2018

Conversation

brisad
Copy link
Contributor

@brisad brisad commented Sep 19, 2018

@fitzgen
Copy link
Member

fitzgen commented Sep 19, 2018

CI failure is unrelated, comes from two merges that don't literally conflict, but still logically conflict.

fitzgen
fitzgen approved these changes Sep 19, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks @brisad :)

@fitzgen fitzgen merged commit b36708f into rustwasm:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brisad @fitzgen