Skip to content

Discussion #1599, increase/decrease width/height shortcut#1652

Merged
rxhanson merged 8 commits into
rxhanson:mainfrom
thenickygee:1599
Oct 14, 2025
Merged

Discussion #1599, increase/decrease width/height shortcut#1652
rxhanson merged 8 commits into
rxhanson:mainfrom
thenickygee:1599

Conversation

@thenickygee

Copy link
Copy Markdown
Contributor

PR Summary

Requirements from @rxhanson

  • "I'm open to having something like an "even more settings" button"
  • "opens a popover with more settings where this can go"
  • "prefer that the button lives in the General tab at first"

Tests Passing

  • Test Suite 'All tests' passed at 2025-10-05
  • Executed 2 tests, with 0 failures (0 unexpected) in 0.350 seconds
image

@rxhanson

rxhanson commented Oct 6, 2025

Copy link
Copy Markdown
Owner

Looks good! I'll test things out soon, but I don't see any issues with the changes so far.

@rxhanson rxhanson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, and everything works great. A few points worth mentioning:

  1. We can change the widthStepSize default to have a default value of 30 in Defaults.swift, and then we don't have to repeat the default value in two places. (I know that this wasn't the way it was previously, but it makes sense to have it that way now).
  2. It would fit with the style of the shortcuts tab to have the text in the popover right aligned, for both the additional shortcuts and the step size components.
  3. We'll need the text that's in the popover to be added to the Main.xcstrings, otherwise it won't get translated when the community looks to translate it.

I don't mind merging as-is and making these changes, but would definitely appreciate it if you went ahead and made those changes. I'll hold off on merging immediately if you would like to make those changes.

Thanks again for contributing!

@thenickygee

Copy link
Copy Markdown
Contributor Author

I can totally make these needed changes. I'm tracking everything you're requesting and will get my PR updated.

And of course- happy to be helping out 🤝

@thenickygee

thenickygee commented Oct 13, 2025

Copy link
Copy Markdown
Contributor Author

@rxhanson got changes in to address these requests:

Changes Summary

  • We can change the widthStepSize default to have a default value of 30 in Defaults.swift...

    • Added widthStepSize defaultValue and replaced existing hard coded definitions
  • It would fit with the style of the shortcuts tab to have the text in the popover right aligned...

    • Right aligned text and input content. Center aligned popover title (I felt like the left aligned title looked a bit weird with the new right alignment. Was also thinking about removing the title to the popover altogether but will leave that up to you)
  • We'll need the text that's in the popover to be added to the Main.xcstrings...

    • Added 'extra shortcuts' strings to Main.xcstrings (followed existing patterns) and wrapped the labels with NSLocalizedString.

Tests Passing

  • Test Suite 'All tests' passed at 2025-10-12
  • Executed 2 tests, with 0 failures in 0.338 seconds
1599-new-screenshot

@thenickygee thenickygee requested a review from rxhanson October 13, 2025 03:45
@rxhanson rxhanson merged commit 04e4e3f into rxhanson:main Oct 14, 2025
1 check passed
@rxhanson

Copy link
Copy Markdown
Owner

Excellent! Thanks!

@thenickygee thenickygee deleted the 1599 branch October 15, 2025 02:52
liangyuetian added a commit to liangyuetian/Rectangle.For.Windows that referenced this pull request Mar 19, 2026
…hanson#1652)

* Adding new button for 'more settings' popover in general tab

* Added increaseWidth and decreaseWidth shortcuts to 'extra settings' button in general menu

* Added 'Width Step' value in 'extra settings' general popover

* Added images for new width shortcuts in 'extra settings' general popover

* Added widthStepSize default value to Defaults.swift

* Right aligned content in 'extra settings' general popover

* Added 'extra shortcuts' strings to Main.xcstrings and wrapped existing labels with NSLocalizedString
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants