Discussion #1599, increase/decrease width/height shortcut#1652
Conversation
…utton in general menu
|
Looks good! I'll test things out soon, but I don't see any issues with the changes so far. |
There was a problem hiding this comment.
Tested it out, and everything works great. A few points worth mentioning:
- We can change the
widthStepSizedefault to have a default value of 30 in Defaults.swift, and then we don't have to repeat the default value in two places. (I know that this wasn't the way it was previously, but it makes sense to have it that way now). - It would fit with the style of the shortcuts tab to have the text in the popover right aligned, for both the additional shortcuts and the step size components.
- We'll need the text that's in the popover to be added to the Main.xcstrings, otherwise it won't get translated when the community looks to translate it.
I don't mind merging as-is and making these changes, but would definitely appreciate it if you went ahead and made those changes. I'll hold off on merging immediately if you would like to make those changes.
Thanks again for contributing!
|
I can totally make these needed changes. I'm tracking everything you're requesting and will get my PR updated. And of course- happy to be helping out 🤝 |
|
@rxhanson got changes in to address these requests: Changes Summary
Tests Passing
|
|
Excellent! Thanks! |
…hanson#1652) * Adding new button for 'more settings' popover in general tab * Added increaseWidth and decreaseWidth shortcuts to 'extra settings' button in general menu * Added 'Width Step' value in 'extra settings' general popover * Added images for new width shortcuts in 'extra settings' general popover * Added widthStepSize default value to Defaults.swift * Right aligned content in 'extra settings' general popover * Added 'extra shortcuts' strings to Main.xcstrings and wrapped existing labels with NSLocalizedString

PR Summary
Requirements from @rxhanson
Tests Passing