Add open_in_browser configuration option to control automatic email opening #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmer
commented
Jun 7, 2025
cmer
commented
- Add open_in_browser attribute to Configuration class with default value true
- Support boolean values (true/false) to enable/disable browser opening
- Support callable/proc values for dynamic conditional opening based on email properties
- Update DeliveryMethod to respect open_in_browser setting before calling Launchy.open
- Add comprehensive test coverage for all open_in_browser scenarios
- Maintain backward compatibility with existing behavior
…pening - Add open_in_browser attribute to Configuration class with default value true - Support boolean values (true/false) to enable/disable browser opening - Support callable/proc values for dynamic conditional opening based on email properties - Update DeliveryMethod to respect open_in_browser setting before calling Launchy.open - Add comprehensive test coverage for all open_in_browser scenarios - Maintain backward compatibility with existing behavior 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add detailed configuration examples for open_in_browser option - Show boolean usage (true/false) and callable/proc examples - Update Non Rails Setup examples to include open_in_browser option - Document usage with Mail, Pony, and ActionMailer configurations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Author
|
For context, I use this in conjunction with letter_opener_web. I just don't want every email to open in my browser all the time, especially not when I "send" hundreds of emails at once in development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.