Skip to content

Conversation

@haennes
Copy link

@haennes haennes commented Nov 27, 2023

Will get the local time based on the timezone reported by the device instead of utc0 which should make a lot more sense for this paticular use case

@iangray001
Copy link
Collaborator

This is a breaking change, so probably should be added as another time component instead of changing the behaviour of the existing one.

@haennes
Copy link
Author

haennes commented Nov 28, 2023

Yes indeed. I could write it to use the name LocalTime instead. Whats the best Name for it?

@iangray001
Copy link
Collaborator

LocalTime is a good suggestion, thanks.

@haennes
Copy link
Author

haennes commented Nov 29, 2023

Should the LocalTime be updated when updateTime() is called or should another Function be added as well?

@iangray001
Copy link
Collaborator

I would suggest both be updated from updateTime()

@haennes
Copy link
Author

haennes commented Dec 15, 2023

I have change on the local_time branch in my fork
I will close this PR in favor of a new one pulling from the fork.
This is to not clutter the git history of the repo.
Also: I dont have the Hardware anymore to compile and test the changes. Could sb else please test this?

@haennes haennes closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants