-
Notifications
You must be signed in to change notification settings - Fork 190
User-defined CSS #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emmby
wants to merge
16
commits into
s00500:master
Choose a base branch
from
emmby:setPanelClass
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
User-defined CSS #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces `setCustomCSS` to the ESPUI class, allowing users to inject custom CSS into the web interface, analogous to `setCustomJS`. Changes include: - Added `setCustomCSS` method to `ESPUI.h` and `ESPUI.cpp`. - Added `/css/custom.css` route handler in `ESPUI.begin`. - Updated `src/dataIndexHTML.h` to include the link to `/css/custom.css` in both `HTML_INDEX` and `HTML_INDEX_GZIP`.
This commit introduces `setCustomCSS` to the ESPUI class, allowing users to inject custom CSS into the web interface, analogous to `setCustomJS`. Changes include: - Added `setCustomCSS` method to `ESPUI.h` and `ESPUI.cpp`. - Added `/css/custom.css` route handler in `ESPUI.begin`. - Updated `data/index.htm` to include the link to `/css/custom.css`. - Regenerated static UI sources (minified files and C headers) using `tools/prepare_static_ui_sources.py`.
This commit introduces `setCustomCSS` to the ESPUI class, allowing users to inject custom CSS into the web interface, analogous to `setCustomJS`. Changes include: - Added `setCustomCSS` method to `ESPUI.h` and `ESPUI.cpp`. - Added `/css/custom.css` route handler in `ESPUI.begin`. - Updated `data/index.htm` to include the link to `/css/custom.css`. - Updated `src/dataIndexHTML.h` and `data/index.min.htm` with the regenerated content including the new link. - Reverted unintended changes to other generated files.
This commit introduces `setCustomCSS` to the ESPUI class, allowing users to inject custom CSS into the web interface, analogous to `setCustomJS`. Changes include: - Added `setCustomCSS` method to `ESPUI.h` and `ESPUI.cpp`. - Added `/css/custom.css` route handler in `ESPUI.begin`. - Updated `data/index.htm` to include the link to `/css/custom.css`. - Regenerated static UI sources (minified files and C headers) using `tools/prepare_static_ui_sources.py` for index.htm. - Updated README.md with usage instructions.
emmby
added a commit
to emmby/WatchTower
that referenced
this pull request
Nov 30, 2025
depends on a fork of ESPUI s00500/ESPUI#335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #333, this PR enable the user to specify user-defined CSS using
setCustomCSS.The CSS is served at /css/custom.css, which is empty if no user-defined CSS is specified.
In addition, a method
setPanelClassis supplied which allows the user to specify user-specified CSS classes on the panel div. UsingsetCustomCSSandsetPanelClasstogether enables more flexible styling changes than just usingsetPanelStyleorsetElementStylealone (eg. enabling styling on nested elements within the panel).Enables more complex styling such as the styling of the table here: emmby/WatchTower#11