Skip to content

fix(report): Add commas between tags in generated markdown #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025
Merged

fix(report): Add commas between tags in generated markdown #553

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
379ae67
Seperate Tags with Comma in Report
tejakummarikuntla Jul 31, 2025
f9b1e0c
Merge branch 'main' into report-tag-separation
tejakummarikuntla Jul 31, 2025
7d9b652
Delete pkg/.DS_Store
tejakummarikuntla Jul 31, 2025
b3badea
Update pkg/reporter/markdown.go
tejakummarikuntla Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added pkg/.DS_Store
View file
Open in desktop
Binary file not shown.
3 changes: 2 additions & 1 deletion pkg/reporter/markdown.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"os"
"sync"
"text/template"
"strings"

"github.com/safedep/vet/pkg/analyzer"
"github.com/safedep/vet/pkg/common/logger"
Expand Down Expand Up @@ -128,7 +129,7 @@
Pkg: s.pkg,
PkgRemediationName: sr.packageNameForRemediationAdvice(s.pkg),
Score: s.score,
Tags: fmt.Sprintf("%s", s.tags),
Tags: fmt.Sprintf("%s", strings.Join(s.tags, ", ")),

Check failure on line 132 in pkg/reporter/markdown.go

View workflow job for this annotation

GitHub Actions / lint 

S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
})

if _, ok := summaries[mp]; !ok {
Expand Down
2 changes: 1 addition & 1 deletion pkg/reporter/markdown.template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
| Major Version Differences | {{ .DriftLibsCount }} |
| Manifests | {{ .ManifestsCount }} |
| Total Packages | {{ .PackagesCount }} |
| Exepmted Packages | {{.ExemptedLibs}} |
| Exempted Packages | {{.ExemptedLibs}} |



Expand Down
Loading