Meson: add building of documentation as target #39973
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some file permission goes wrong? (symbolic link get converted to normal file?) |
user202729
reviewed
Apr 19, 2025
| docs = [doc[1] for doc in sorted(documents)] | ||
| # Put the bibliography first, because it needs to be built first: | ||
| docs.remove(Path('reference/references')) | ||
| docs.insert(0, Path('reference/references')) |
There was a problem hiding this comment.
Why is such a large change necessary in this file?
There was a problem hiding this comment.
To be honest, I got carried a way a bit: the strictly necessary change is to remove mentions of import sage, then I used the chance to use pathlib, and to catch all those paths vs strings issues added typing info. Oh, and there were a few old deprecated stuff in there which was easier to remove than to migrate to pathlib 🦊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to build the documentation with meson via
For this a couple of changes was necessary in the docbuilder:
sage_docbuildindependent ofsageso that meson can usesage_docbuildduring config time to construct all the docbuild targets (otherwise one needs to first install sage, and then could configure the docbuild)📝 Checklist
⌛ Dependencies