-
-
Notifications
You must be signed in to change notification settings - Fork 631
Migrate "long" ci tests to Meson #40158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Technically this "works" too (if it works properly). Let's see. |
.github/workflows/ci-meson.yml
Outdated
@@ -42,6 +45,11 @@ jobs: | |||
- os: windows | |||
python: '3.13' | |||
tests: 'all' | |||
exclude: | |||
# Exclude 'all' since we already have 'long' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it's time to consider having a more descriptive name. new
(both short and long), short
, long
(this should really be all
, but that's doubly confusing because all
currently means all short
)?
(if you mean |
@@ -373,15 +373,3 @@ exclude = | |||
sage/combinat/designs/database.py | |||
sage/graphs/graph_plot.py | |||
sage/misc/sagedoc.py | |||
|
|||
[coverage:run] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there anything else that still uses tox?
the Maybe try changing it to |
Do you understand what's going on here? The queue has a max limit of 1, because it is supposed to hold only one doctest result. I don't see why it would try to put more than one result in there. The code also doesn't seem to reuse the queue across workers/doctests. |
no idea either, but some StackOverflow post claims this may be caused when the object being passed around is too large (I can't reproduce this on my side though). In that case it sounds like blocking=True might help. Worst case we can add some debugging there (print out what's the current length), modulo race conditions. |
it's not helping either. I'll see if I can reproduce the issue locally… edit: I cannot. debugging with #40161 edit: feels like a weird bug in Now continue debugging. |
sanity check, is test-new currently running long tests? (it's supposed to be.) |
Documentation preview for this PR (built with commit c9b6d07; changes) is ready! 🎉 |
Fixes #40120.
Sage-the-distro is still tested using ci-incremental.
📝 Checklist
⌛ Dependencies