Restore release notes creation step #40843
Open
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
force-pushed
the
p/restore-release-notes-step
branch
from
67fe542 to
c95f3fa
Compare
|
Documentation preview for this PR (built with commit b47b032; changes) is ready! 🎉 |
kwankyu
force-pushed
the
p/restore-release-notes-step
branch
from
c95f3fa to
a2bdb5e
Compare
kwankyu
force-pushed
the
p/restore-release-notes-step
branch
from
a2bdb5e to
b47b032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the issue discussed in https://groups.google.com/g/sage-devel/c/LFfhN0CpGJ8.
However, we retain the idea of #40709 that a github release is made only in one step in the workflow. Previously, before #40709, a github release was made in two steps "Create release" and "Create release assets". This strategy worked well but started failing some months ago.
Test (with #40840): https://github.com/kwankyu/sage/actions/runs/17846547780.
📝 Checklist
⌛ Dependencies