-
Notifications
You must be signed in to change notification settings - Fork 221
dev: consistency checker for npm packages #4191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
output right now:
|
313da74
to
8b09e46
Compare
f5f5334
to
306ee66
Compare
… that info when doing dev work
306ee66
to
33488c7
Compare
Nice use of mypy typing... when/how would the typing get checked ? |
well, those are the usual type annotations. you can use mypy, but also pycharm, vscode (pyright?) and several others to check. the canonical one is probably mypy. run it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
just an idea, this could help us getting insight/warnings about version inconsistencies (e.g. as part of CI testing)
the only change that touches anything is calling this at the start of
webpack-watch
, to give us some feedback. Later, once this is down to zero inconsistencies, we can add it to travis CI to inform us about introducing new ones.Testing Steps
Relevant Issues
Checklist:
Front end:
~/.smc/local_hub/local_hub.log
./w
in/src
./start_hub.py
in/src/dev/project