Skip to content

dev: consistency checker for npm packages #4191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2019
Merged

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Oct 23, 2019

Description

just an idea, this could help us getting insight/warnings about version inconsistencies (e.g. as part of CI testing)

the only change that touches anything is calling this at the start of webpack-watch, to give us some feedback. Later, once this is down to zero inconsistencies, we can add it to travis CI to inform us about introducing new ones.

Testing Steps

Relevant Issues

Checklist:

  • No debugging console.log messages.
  • All new code is actually used.
  • Non-obvious code has some sort of comments.

Front end:

  • Restart at least one project and check its ~/.smc/local_hub/local_hub.log
  • Completely restart Webpack with ./w in /src
  • Completely restart the hub by killing and restarting ./start_hub.py in /src/dev/project
  • Screenshots if relevant.

@haraldschilly
Copy link
Contributor Author

haraldschilly commented Oct 23, 2019

output right now:

                              cocalc-ui      jupyter        puppeteer      smc-hub        smc-project    smc-util       smc-util-node  smc-webapp     
@types/jquery                                                                             ^3.3.31                                      ^3.3.29        
@types/node                                                                ^12.7.11       ^12.7.11       ^12.7.5                                      
ansi-to-react                                ^1.1.1                                                                                    ^2.0.1         
async                                                                      ^1.4.2         ^1.5.0         ^1.4.2         ^1.4.2         ^2.6.1         
async-await-utils                                                          ^3.0.1         ^2.0.4         ^2.0.4                        ^2.0.4         
coffee-loader                                                              ^0.7.2         ^0.9.0                                                      
commander                                                                  ^2.6.0         ^2.9.0                                                      
express                                                                    ^4.11.2        ^4.13.3                                                     
formidable                                                                 ^1.0.17        ^1.1.1                                       ^1.2.1         
immutable                                                                  ^3.7.5                        ^3.7.5                        ^4.0.0-rc.12   
jsdom                                                                      ^11.3.0                                      ^7.2.2                        
json-stable-stringify                        ^1.0.1                        ^1.0.1         ^1.0.1         ^1.0.1                        ^1.0           
lru-cache                                                                                 ^4.1.3                                       ^5.1.1         
node-cleanup                                 ^2.1                                         ^2.1.2                                                      
primus                                                                     ^7.3.3         ^7.3.2                                                      
prop-types                                   ^15.7.2                                                     ^15.5.10                      ^15.7.2        
serve-index                                                                ^1.9.1         ^1.7.2                                                      
winston                                                                    ^2.4           ^1.1.1                        ^1.1.1                      

@haraldschilly haraldschilly force-pushed the npm-check-packages branch 2 times, most recently from f5f5334 to 306ee66 Compare October 25, 2019 12:49
@williamstein
Copy link
Contributor

Nice use of mypy typing... when/how would the typing get checked ?

@williamstein williamstein merged commit 4fd8174 into master Oct 26, 2019
@haraldschilly
Copy link
Contributor Author

Nice use of mypy typing... when/how would the typing get checked ?

well, those are the usual type annotations. you can use mypy, but also pycharm, vscode (pyright?) and several others to check. the canonical one is probably mypy. run it via mypy [filename].py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants