-
Couldn't load subscription status.
- Fork 1
chore: update dependencies #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies #43
Conversation
|
@reneleonhardt thanks for the PR! Seems like there are issues with PyPy3.11 and Python 3.14, would you have some time to look into resolving these? If not, we can remove the added support in this PR, and we could try to come back to that topic in the future There is also one type check failing (mypy), a |
|
I wonder why CI isn't allowed to run automatically, can you enable it for faster feedback? pytest has not been released yet since all the Python 3.14 fixes over the last months, for example the mark / decorators support which is breaking tests here: Is pinning Also locally I couldn't manage to convince poetry to update some transitive dependencies like cryptography which weren't buildable with Python 3.14. |
|
My apologies for the delays, I'm quite swamped currently thus it takes me a while to get back to you. I think the PR should be pretty close from done!
This is due to the fact any change must be reviewed before running them in workflows as they could contain malicious code (that's unfortunately the way GitHub designed actions)
That sounds good to me if you can mark the failing tests as to be skipped for Python 3.14 meanwhile
Yes it's better to pin it in order to ensure the behavior of the workflows is always consistent (we especially want to prevent them from suddenly breaking which can happen however is very rare). I do see it's using a pretty old version of Poetry though thus should be updated.
It's caused by the fact Poetry logsDoing the following fixes the issue (it updated cryptography to diff --git a/pyproject.toml b/pyproject.toml
index 730a045..e95dd04 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -42,7 +42,7 @@ Issues = "https://github.com/saleor/requests-hardened/issues"
Changelog = "https://github.com/saleor/requests-hardened/releases/"
[tool.poetry.dependencies]
-python = ">=3.9,<4.0"
+python = ">=3.9.2,<4.0"
# We require >=2.32.3 due to depending on `get_connection_with_tls_context`.
requests = ">=2.32.3,<3.0.0"I will open a PR to fix that issue (edit: #44) as it prevents us from using the latest version, thanks for noticing! |
|
Why did you duplicate my work into a new PR instead of helping here and merging first? |
Hey! It was because I considered the |
|
Hey @reneleonhardt 👋 As this PR is stale and Python 3.14's release is very soon, I took it upon myself to add Python 3.14 support here: #50 Thank you once again for the changes, and for taking the time to make them 🙇 And sorry for the confusion earlier around the conflicts created by another PR due to implementing same/similar changes |
Chores