-
Notifications
You must be signed in to change notification settings - Fork 433
Add TypeScript typings #2675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript typings #2675
Conversation
Thanks for opening this pull request! 💯 This is a community-driven project, and we can't do it without your participation. Please check out our contributing guidelines and review the Contributor Checklist if you haven't already, to make sure everything is squared away. TravisCI will take about 10 minutes to run through the same items that are on the Contributor checklist with a pass/fail check below. Please fix any issues that cause TravisCI to fail or ask for clarification--we try, but sometimes the errors can be unclear. |
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Volkan Unsal <v***@A***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
Thanks for the contribution! Before we can merge this, we need @volkanunsal to sign the Salesforce.com Contributor License Agreement. |
076e41c
to
d0c7e40
Compare
d0c7e40
to
432f272
Compare
It would be awesome if someone could merge this. |
@interactivellama Could you take a look at this PR? Thanks a lot! |
Will review and test this out, over the weekend. |
Adding the following, so folks in the future know how to use this:
Also, adding that these are not being dynamically generated and may become out of date soon. |
Fixes #1346 |
Congrats on merging your first pull request to Design System React! 🎉 |
@volkanunsal Would you be willing to share how these types were generated? |
I wrote a few comby scripts to extract them from the js files. Then did
some manual cleanup. I can share them if there is interest.
…On Fri, Jan 22, 2021 at 6:26 PM Stephen James ***@***.***> wrote:
@volkanunsal <https://github.com/volkanunsal> Would you be willing to
share how these types were generated?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2675 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFAMC26AG5F557FBFVGT3S3ICTNANCNFSM4TLKZXUA>
.
|
@volkanunsal I'm very interested, can you please share these utilities? |
Additional description
CONTRIBUTOR checklist (do not remove)
Please complete for every pull request
npm run lint:fix
has been run and linting passes.components/component-docs.json
CI tests pass (npm test
).REVIEWER checklist (do not remove)
components/component-docs.json
tests.Required only if there are markup / UX changes
last-slds-markup-review
inpackage.json
and push.last-accessibility-review
, topackage.json
and push.npm run local-update
within locally cloned site repo to confirm the site will function correctly at the next release.