#205 Fix non-determinism in build-data.properties file #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @jgriffiths-od to sign the Salesforce Inc. Contributor License Agreement. |
jpgxs
force-pushed
the
205_fix_build_data_determinism
branch
from
9aad631 to
abeb611
Compare
|
Thanks for the contribution! Before we can merge this, we need @jpgxs to sign the Salesforce Inc. Contributor License Agreement. |
Invoke singlejar with a relative path to the output JAR, preventing the build-data.properties file from containing the absolute path.
jpgxs
force-pushed
the
205_fix_build_data_determinism
branch
from
abeb611 to
971b7c9
Compare
|
I will test within Salesforce (we have a large number of springboot use cases), and cut an official release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invoke singlejar with a relative path to the output JAR, preventing the build-data.properties file from containing the absolute path.
Fixes: #205