Open
Conversation
Reorganize the flat it.each in domainMatch.spec.ts into grouped describe blocks for better readability and alignment with RFC 6265 Section 5.1.3 structure: - null and undefined inputs (library-specific behavior) - canonicalization (mixed case, leading dots, non-ASCII/punycode) - identical strings (RFC condition 1) - suffix matching with dot boundary (RFC condition 2) - IP address rejection (RFC condition 2's IP check) No test cases added or removed — purely structural reorganization. This follows the pattern established in PR #547 for date tests. Part of #513
Add tests for empty string inputs, localhost identity match,
dot-only inputs, and canonicalize=false parameter behavior.
Note: ('..', '.') returns true because canonicalization strips
the leading dot from '..' leaving '.', which matches identity.
Update JSDoc and inline comments to reference specific sections of draft-ietf-httpbis-rfc6265bis-22, note rfc6265bis compatibility in the remarks block, and clearly label library-specific behavior that goes beyond the RFC algorithm. No behavioral changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domainMatch.spec.tsfrom a flatit.eachinto 5 groupeddescribeblocks matching RFC conditions (identical strings, suffix matching, IP address rejection) and library-specific behavior (null/undefined, canonicalization)localhost), dot-only domains, andcanonicalize=falseparameter pathdomainMatch.tswith fine-grained draft-ietf-httpbis-rfc6265bis-22 section anchors and mark library-specific behavior (null handling, optional canonicalization) as not in RFC@remarksNo behavioral or API changes.
Test Plan
vitest run)npm run lint)Closes #513