VMware vCenter proxy + storage policies states & dependencies #43674

alexbleotu · 2017-09-21T14:53:23Z

What does this PR do?

Added a vCenter specific proxy and the functions required to configure storage policies (previously known as storage profiles) on the vCenter. This requires to connect to a different endpoint called /pbm which names the state and utils modules. The execution function is vsphere

Examples of the input expected to configure a storage policy can be found in the sysdoc of salt.states.pbm.

List of functions:
Proxy:

all required functions to run the vcenter proxy
some existing functions and tests in the vsphere module have been adjusted to support the new proxy

Utils functions

get_new_service_instance_stub that creates a new service instance stub
salt.utils.pbm.get_profile_manager
salt.utils.pbm.get_placement_solver
salt.utils.pbm.get_capability_definitions
salt.utils.pbm.get_policies_by_id
salt.utils.pbm.get_storage_policies
salt.utils.pbm.create_storage_policy
salt.utils.pbm.create_storage_policy
salt.utils.pbm.update_storage_policy
salt.utils.pbm.get_default_storage_policy_of_datastore
salt.utils.pbm.assign_default_storage_policy_to_datastore

Execution functions:

salt.modules.vsphere._get_policy_dict that transforms a policy VMware object into a dict representation
salt.modules.vsphere.list_storage_policies that retrieves dict representations of storage policies, filtered by name
salt.modules.vsphere.list_default_vsan_policy that retrieves dict representation of the default storage policies
salt.modules.vsphere._get_capability_definition_dict that transforms a VMware capability definition into a dict representation
salt.modules.vsphere.list_capability_definitions that returns dict representations of VMware capability definition
salt.modules.vsphere._apply_policy_config that applies a storage dict representations values to a object
salt.modules.vsphere.create_storage_policy
salt.modules.vsphere.update_storage_policy
salt.modules.vsphere.list_default_storage_policy_of_datastore that lists the dict representation of the policy assigned by default to a datastore
salt.modules.vsphere.assign_default_storage_policy_to_datastore

States functions:

salt.states.pbm.default_vsan_policy_configured state that configures the default storage policy
salt.states.pbm.storage_policies_configured state that creates/configures storage policies
salt.states.pbm.default_storage_policy_assigned state that manages default storage policies to datastore assigments

Tests written?

Yes (for utils functions)

Please review Salt's Contributing Guide for best practices.

ghost · 2017-09-21T14:53:28Z

@alexbleotu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rallytime, @cro and @s0undt3ch to be potential reviewers.

alexbleotu · 2017-09-21T14:54:46Z

The state functions use some shared methods in #43645 so that needs to be merged in first

cachedout · 2017-09-22T17:47:12Z

@alexbleotu I got #43645 in but there are some merge conflicts now. Could you please resolve them? Thanks.

alexbleotu · 2017-09-22T19:19:55Z

@cachedout rebased and added the pyVmomi incompatibility check. Also #43604

LE: Some tests are fixed in #43604. They will fail here until the other branch is merged.

…ce stub

…tore

…VMware object into a dict representation

…representations of storage policies, filtered by name

…hat lists the dict representation of the policy assigned by default to a datastore

…d other execution modules

…gures the default storage policy

…configures storage policies

…ges default storage policies to datastore assigments

… reference to Python 2.6

rallytime

Very well done!

alexbleotu · 2017-09-27T09:11:03Z

Can we get this merged in? I really need to get both this PR and #43751 (afterwards please) merged in today or tomorrow. Thanks!

rallytime · 2017-09-27T13:36:19Z

re-run py3

cachedout · 2017-09-27T14:57:45Z

salt/utils/vmware.py

@@ -1,5 +1,7 @@
 # -*- coding: utf-8 -*-
 '''
+import sys


Import is in the comment block.

cachedout · 2017-09-27T14:57:55Z

salt/utils/vmware.py

 # -*- coding: utf-8 -*-
 '''
+import sys
+import ssl


Import is in the comment block

my bad will take them out

alexbleotu · 2017-09-27T16:57:51Z

@cachedout all done. Is the GPG required now?

rallytime · 2017-09-27T18:54:49Z

@alexbleotu We're going to be encouraging contributors to sign their commits, but you don't need to do so retroactively.

alexbleotu mentioned this pull request Sep 21, 2017

VMware cluster states + dependencies #43645

Merged

alexbleotu force-pushed the storage_policies-gh branch from 9c10528 to 62f3151 Compare September 22, 2017 19:19

Alexandru Bleotu added 24 commits September 25, 2017 18:18

Added get_new_service_instance_stub that creates a new service instan…

e5ebd28

…ce stub

Added tests for salt.utils.vmware.get_new_service_instance_stub

dd54f8a

Added initial sysdoc and imports of salt.utils.pbm

3e8ed59

Added salt.utils.pbm.get_profile_manager

e77b912

Added tests for salt.utils.pbm.get_profile_manager

6b2ddff

Added salt.utils.pbm.get_placement_solver

c790107

Added tests for salt.utils.pbm.get_placement_solver

68f48d1

Added salt.utils.pbm.get_capability_definitions

eac509b

Added tests for salt.utils.pbm.get_capability_definitions

e980407

Added salt.utils.pbm.get_policies_by_id

f42de9c

Added tests for salt.utils.pbm.get_policies_by_id

d8e0cbd

Added salt.utils.pbm.get_storage_policies

df16bdb

Added tests for salt.utils.pbm.get_storage_policies

7576456

Added salt.utils.pbm.create_storage_policy

d3744c8

Fixed tests for salt.utils.pbm.get_policies_by_id

c80df65

Added tests for salt.utils.pbm.create_storage_policy

d43e342

Added salt.utils.pbm.update_storage_policy

9c05f7c

Added tests for salt.utils.pbm.update_storage_policy

7941970

Added salt.utils.pbm.get_default_storage_policy_of_datastore

61c226c

Added tests for salt.utils.pbm.get_default_storage_policy_of_datastore

5dbbac1

Added salt.utils.pbm.assign_default_storage_policy_to_datastore

20fca4b

Added tests for salt.utils.pbm.assign_default_storage_policy_to_datas…

a3047ad

…tore

Added salt.modules.vsphere._get_policy_dict that transforms a policy …

6da3ff5

…VMware object into a dict representation

Added salt.modules.vsphere.list_storage_policies that retrieves dict …

6bb0111

…representations of storage policies, filtered by name

Alexandru Bleotu added 17 commits September 25, 2017 18:24

Added salt.modules.vsphere.create_storage_policy

a5ae51f

Added salt.modules.vsphere.update_storage_policy

41a65bf

Added salt.modules.vsphere.list_default_storage_policy_of_datastore t…

582919f

…hat lists the dict representation of the policy assigned by default to a datastore

Added salt.modules.vsphere.assign_default_storage_policy_to_datastore

0b2b796

Added VCenterProxySchema JSON schema that validates the vcenter proxy

507910b

Added vcenter proxy

176222b

Added salt.modules.vcenter shim execution module between the proxy an…

483fa0d

…d other execution modules

Added support for vcenter proxy in salt.modules.vsphere

94929d5

Updated all vsphere tests to support the vcenter proxy

58445e9

Comments, imports, init function in salt.states.pbm

da39e7c

Added salt.states.pbm.default_vsan_policy_configured state that confi…

9f96c1f

…gures the default storage policy

Added salt.states.pbm.storage_policies_configured state that creates/…

bb52e0d

…configures storage policies

Added salt.states.pbm.default_storage_policy_assigned state that mana…

36fc89c

…ges default storage policies to datastore assigments

pylint

b6577e4

more pylint

f484bd5

Removed excs reference from new methods in salt.modules.vsphere

e1bfe24

Added python/pyvmomi compatibility check to salt.states.pbm + removed…

4ff745d

… reference to Python 2.6

alexbleotu force-pushed the storage_policies-gh branch from 9acd2e6 to 4ff745d Compare September 25, 2017 22:27

Fixed utils.pbm unit tests

ac79f89

rallytime approved these changes Sep 26, 2017

View reviewed changes

rallytime requested a review from cachedout September 26, 2017 14:03

Merge branch 'develop' into storage_policies-gh

c51891c

cachedout suggested changes Sep 27, 2017

View reviewed changes

Removed commented imports

5c3109f

rallytime merged commit e4be436 into saltstack:develop Sep 27, 2017

alexbleotu deleted the storage_policies-gh branch September 28, 2017 08:44

VMware vCenter proxy + storage policies states & dependencies #43674

VMware vCenter proxy + storage policies states & dependencies #43674

Uh oh!

Conversation

alexbleotu commented Sep 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Tests written?

Uh oh!

ghost commented Sep 21, 2017

Uh oh!

alexbleotu commented Sep 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cachedout commented Sep 22, 2017

Uh oh!

alexbleotu commented Sep 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rallytime left a comment

Choose a reason for hiding this comment

Uh oh!

alexbleotu commented Sep 27, 2017

Uh oh!

rallytime commented Sep 27, 2017

Uh oh!

cachedout Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

alexbleotu Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

cachedout Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

alexbleotu Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

alexbleotu Sep 27, 2017

Choose a reason for hiding this comment

Uh oh!

alexbleotu commented Sep 27, 2017

Uh oh!

rallytime commented Sep 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alexbleotu commented Sep 21, 2017 •

edited

Loading

alexbleotu commented Sep 21, 2017 •

edited

Loading

alexbleotu commented Sep 22, 2017 •

edited

Loading