issue#50: fix partial_diff #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyrexMinus
reviewed
Nov 20, 2023
smart_kit/utils/diff.py
Outdated
| if expected != actual and \ | ||
| not (isinstance(actual, str) and isinstance(expected, str) and re.fullmatch(expected, actual)): | ||
| if (not isinstance(actual, type(expected)) or | ||
| (isinstance(actual, str) and isinstance(expected, str) and |
There was a problem hiding this comment.
Suggested change
| (isinstance(actual, str) and isinstance(expected, str) and | |
| (isinstance(actual, str) and |
Из предыдущего экспрешна следует, что типы совпадают
SyrexMinus
reviewed
Nov 20, 2023
smart_kit/utils/diff.py
Outdated
| @@ -20,8 +20,10 @@ def __init__(self): | |||
| @classmethod | |||
| def partial_diff(cls, expected: Any, actual: Any, path="", dict_check_does_not_expected=False) -> Diff: | |||
| diff = cls() | |||
| if expected != actual and \ | |||
| not (isinstance(actual, str) and isinstance(expected, str) and re.fullmatch(expected, actual)): | |||
| if (not isinstance(actual, type(expected)) or | |||
There was a problem hiding this comment.
Suggested change
| if (not isinstance(actual, type(expected)) or | |
| if not isinstance(actual, type(expected) or |
SyrexMinus
reviewed
Nov 20, 2023
smart_kit/utils/diff.py
Outdated
| if (not isinstance(actual, type(expected)) or | ||
| (isinstance(actual, str) and isinstance(expected, str) and | ||
| expected != actual and not re.fullmatch(expected, actual)) or | ||
| expected != actual): |
There was a problem hiding this comment.
Если там была регулярка, это зафейлится
SyrexMinus
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #50